Waiting attach operation to be finished rather than returning nil #47018
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @FengyunPan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-github-robot
added
size/L
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
@k8s-bot ok to test |
k8s-ci-robot
removed
the
needs-ok-to-test
pkg/volume/cinder/attacher.go
Outdated
| } | ||
| } else { | ||
| return false, err | ||
| } |
There was a problem hiding this comment.
Can we rewrite this as
if err != nil {
return false, err
}
return !pending, nil
pkg/volume/cinder/attacher.go
Outdated
| } | ||
| } else { | ||
| return false, err | ||
| } |
There was a problem hiding this comment.
similar thing, it is easier to read:
if err != nil {
return false, err
}
return attached, nil
pkg/volume/cinder/attacher.go
Outdated
| if err = attacher.waitDiskAttached(instanceID, volumeID); err != nil { | ||
| glog.Errorf("Error waiting for volume %q to be attached from node %q: %v", volumeID, nodeName, err) | ||
| return "", err | ||
| } else { |
There was a problem hiding this comment.
there is no need of else here I think, because return will anyway make the control to return from the function.
|
/approve |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
added
the
approved
|
/lgtm Thanks for doing this so quickly! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FengyunPan, msau42, saad-ali Associated issue: 46882 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 46977, 47005, 47018, 47061, 46809) |
Automatic merge from submit-queue (batch tested with PRs 46977, 47005, 47018, 47061, 46809) Waiting attach operation to be finished rather than returning nil Fixes kubernetes#46882
Fixes #46882